Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: translation issue for change theme #8199

Merged
merged 3 commits into from
Jun 30, 2023
Merged

fix: translation issue for change theme #8199

merged 3 commits into from
Jun 30, 2023

Conversation

mahdiyeh-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • fix translasion issue

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the Core label Apr 10, 2023
@vercel
Copy link

vercel bot commented Apr 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 3:45am

@sonarcloud
Copy link

sonarcloud bot commented Apr 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.6% 3.6% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/8199](https://github.com/binary-com/deriv-app/pull/8199)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-mahdiyeh-deriv-93000-fixchangethemetr-45480a.binary.sx?qa_server=red.binaryws.com&app_id=32228
    - **Original**: https://deriv-app-git-fork-mahdiyeh-deriv-93000-fixchangethemetr-45480a.binary.sx
- **App ID**: `32228`

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-mahdiyeh-deriv-93000-fixchangethemetr-45480a.binary.sx/

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023 •
edited by codecov bot
Loading

Codecov Report

Merging #8199 (fe67853) into master (d5c38a0) will increase coverage by 20.67%.
The diff coverage is n/a.

❗ Current head fe67853 differs from pull request most recent head afc1ee1. Consider uploading reports for the commit afc1ee1 to get more accurate results

@@             Coverage Diff             @@
##           master    #8199       +/-   ##
===========================================
+ Coverage    0.05%   20.73%   +20.67%     
===========================================
  Files         117     1539     +1422     
  Lines        3425    35916    +32491     
  Branches      893     7012     +6119     
===========================================
+ Hits            2     7448     +7446     
- Misses       3423    27748    +24325     
- Partials        0      720      +720
Impacted Files Coverage Δ
...e/src/App/Containers/Layout/trading-hub-footer.jsx 0.00% <ø> (ø)

... and 1582 files with indirect coverage changes

@github-actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 10, 2023
@github-actions
Copy link
Contributor

This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed.

@github-actions github-actions bot closed this Jun 15, 2023
@hamid-deriv hamid-deriv reopened this Jun 28, 2023
@gitguardian
Copy link

gitguardian bot commented Jun 28, 2023 •
edited
Loading

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 2ab1ebf packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx View secret
- Generic High Entropy Secret 2ab1ebf packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@github-actions github-actions bot removed the Stale label Jun 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.1% 4.1% Duplication

@ali-hosseini-deriv ali-hosseini-deriv merged commit b14273f into binary-com:master Jun 30, 2023
2 of 3 checks passed
@ali-hosseini-deriv
Copy link
Member

✨ PR has been merged by Paimon the Release Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amina-deriv amina-deriv amina-deriv approved these changes

Assignees
No one assigned
Labels
Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mahdiyeh-deriv @codecov-commenter @ali-hosseini-deriv @amina-deriv @hamid-deriv